Reduce spacing between consecutive <dt> elements#2811
Reduce spacing between consecutive <dt> elements#2811liuliu-dev merged 11 commits intoprimer:mainfrom
<dt> elements#2811Conversation
🦋 Changeset detectedLatest commit: a57f41c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
github-actions
bot
added
Stale
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the visual presentation of HTML definition lists by reducing spacing between consecutive <dt> (definition term) elements to better indicate they share a common definition.
- Adds CSS rule to remove top margin from consecutive
<dt>elements - Includes changelog entry for the minor version update
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/markdown/lists.scss | Adds CSS selector dt + dt with margin-top: 0 to remove spacing between consecutive definition terms |
| .changeset/thirty-berries-sing.md | Documents the change for the next minor release of @primer/css |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
@emilybrick sorry to ping you, but apparently the bot tries to close this issue in 7 days and this pull request is still relevant, so please keep it open (or review and merge it 😉). Thanks! 🙂 |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
Please keep this open, it is still relevant. |
lesliecdubs
requested review from
a team,
liuliu-dev and
lukasoppermann
and removed request for
emilybrick
|
Sorry for the delay @FloEdelmann! |
liuliu-dev
left a comment
liuliu-dev
left a comment
There was a problem hiding this comment.
LGTM! Left feedback, but non-blocking.
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
@liuliu-dev thanks for the review! I applied your suggestion to the changeset. |
FloEdelmann
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
@liuliu-dev is there anything missing to get this merged? |
FloEdelmann
had a problem deploying
to
github-pages
GitHub Actions
Failure
FloEdelmann
had a problem deploying
to
github-pages
GitHub Actions
Failure
liuliu-dev
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
@FloEdelmann Nothing obvious is missing from the code side, but CI is currently failing. I’m checking with the team on how they want to handle it. I’ll update you once we know the right next step. |
|
Thank you for merging! |
What are you trying to accomplish?
See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dt:
Example usage on GitHub: https://github.com/tummychow/git-absorb/blob/master/Documentation/git-absorb.adoc
Currently, those are separated by a 1rem margin, making them look like separate definitions (without a description):
What approach did you choose and why?
Reduce the spacing between consecutive
<dt>elements to zero:This is a similar approach to consecutive
<li>elements and makes definition lists more readable.What should reviewers focus on?
–
Can these changes ship as is?